Add a canonical rustfmt config #86
Conversation
content/wiki/formatting_scheme.md
Outdated
| # Forces let else blocks to always be their own line(s) | ||
| single_line_let_else_max_width = 0 |
There was a problem hiding this comment.
If we do decide to set this, I'd expect it to have the same value as single_line_if_else_max_width, I think.
There was a problem hiding this comment.
Indeed, they seem very similar and have identical default values.
content/wiki/formatting_scheme.md
Outdated
| use_field_init_shorthand = true | ||
|
|
||
| # Forces let else blocks to always be their own line(s) | ||
| single_line_let_else_max_width = 0 |
There was a problem hiding this comment.
Obviously this isn't used at all in Linebender yet. This is a reasonable value, but I'd lean more towards keeping the default without very good reason, for consistency with the rest of the ecosystem.
This is certainly more taste based than the other two options here.
There was a problem hiding this comment.
For what it's worth I copy-pasted it from the xilem repo.
There was a problem hiding this comment.
Hmm. Fair. I don't care that much either way.
There was a problem hiding this comment.
Yeah we approved it in xilem#305. What I said back then still applies for me: it's quite minor and so I don't personally care much either way.
I believe this was originally added by you @PoignardAzur. So if you still think it's worth having, then I'm fine with it and don't want to bikeshed it. However, if you're not arguing for its benefit, then I don't think we have anyone doing that and we should omit it by default as Daniel mentioned.
There was a problem hiding this comment.
Sorry, I dropped the ball on this for a while. I'll make a separate PR to add it with a better justification.
Co-authored-by: Kaur Kuut <[email protected]>
We can always add it back later
|
To get this out of its stalled state, I've removed the |
|
I've not handled the imports ordering stuff; we can easily do that as a follow-up, especially since it's still unstable. |
No description provided.